Fix overrides for non-shared ArrayBuffer views #2206
Conversation
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
|
Interesting, LGTM |
|
There was an issue merging, maybe try again saschanaz. Details |
|
LGTM |
|
There was an issue merging, maybe try again saschanaz. Details |
|
What? 🙄 lgtm |
|
There was an issue merging, maybe try again saschanaz. Details |
|
I rotated a bunch of tokens, maybe I broke this one. Will fix soon |
|
Can you try again? |
|
LGTM |
|
There was an issue merging, maybe try again saschanaz. Details |
|
Okay, well that's quite confusing. |
|
The token I rotated isn't even the one used by this workflow, which is just the regular github actions token. Weird. Maybe they broke yet another thing in the workflow :( I'll just merge it. |
|
This is why I need a real permission rather than a workflow workaround |
3 participants
Fixes a couple of divergences from the specifications:
WebSocket#send()was previously overridden back in 2018 to accept shared array buffers and array buffer views. The parameter isn't[AllowShared]in the specification, so this is simply inaccurate.extendsclause of a couple of interface methods is currently set toArrayBufferViewwhen it should beArrayBufferView<ArrayBuffer>. Becauseextendsis a manually defined field, it doesn't honour useGenericTypedArrays, so this needs to be indirectly resolved for compatibility with TS 5.6 and earlier.